Jp okta 468586 broadcast channel #1124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuowu
reviewed
Feb 25, 2022
lib/ServiceManager.ts
Outdated
| this.elector = undefined; | ||
| } | ||
|
|
||
| private createService(name: string): ServiceInterface | undefined { |
There was a problem hiding this comment.
We should be able to remove undefined from the type, as it throws instead of returning undefined.
jaredperreault-okta
force-pushed
the
jp-OKTA-468586-broadcast-channel
branch
2 times, most recently
from
8c04d9d to
f62a87d
Compare
shuowu
reviewed
Mar 2, 2022
|
|
||
| In version `6.X`, the `autoRenew` configuration was set in `config.tokenManager`. To maintain backwards compatibility, this configuration is still respected but with a slight caveat. `tokenManager.autoRenew` configures 2 token auto renew strategies, `active` and `passive`. | ||
| * `active` - Network requests are made in the background in an attempt to refresh tokens before they are truly expired to maintain a seamless UX. | ||
| > :warning: this can cause an unintended side effect where the session never expires because it is constantly being refreshed (extended) before the actual expiration time |
| private options: ServiceManagerOptions; | ||
| private services: Map<string, ServiceInterface>; | ||
| private channel?: BroadcastChannel; | ||
| private elector?: LeaderElector; |
There was a problem hiding this comment.
should the elector logic belong to syncService?
| private sdk: OktaAuth; | ||
| private options: ServiceManagerOptions; | ||
| private services: Map<string, ServiceInterface>; | ||
| private channel?: BroadcastChannel; |
| private renewTimeQueue: Array<number>; | ||
| private started = false; | ||
|
|
||
| constructor(tokenManager: TokenManager, options: ServiceManagerOptions = {}) { |
There was a problem hiding this comment.
pass oktaAuth in constructor, so both serviceManager and tokenManager can be available in each service class.
jaredperreault-okta
force-pushed
the
jp-OKTA-468586-broadcast-channel
branch
from
d7f308a to
ca9c8dc
Compare
shuowu
approved these changes
Mar 3, 2022
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Mar 3, 2022
OKTA-468586 <<<Jenkins Check-In of Tested SHA: f1acdd4 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 29 PR Link: "#1124"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.