Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error handling for IDX actions #1160

Closed
wants to merge 4 commits into from

Conversation

aarongranick-okta
Copy link
Contributor

Fixes a bug in error handling for IDX actions.
"remediators" was being passed to the handler instead of "remediator".
Tests for remediate.ts are coming in a follow-up PR

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.49%. Comparing base (71c3352) to head (4295de6).
Report is 2 commits behind head on 6.3.

Files with missing lines Patch % Lines
lib/idx/remediate.ts 60.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              6.3    #1160   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files         159      159           
  Lines        4477     4477           
  Branches      992      992           
=======================================
  Hits         4141     4141           
  Misses        316      316           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aarongranick-okta aarongranick-okta changed the base branch from master to 6.3 March 31, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants