fixes type declarations #1184
Closed
fixes type declarations #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aarongranick-okta
commented
Apr 15, 2022
aarongranick-okta
commented
- some properties and types were missing, needed for Sign-in Widget
- consolidate IDX options to its own file, use interface instead of type to allow ambient declaration merging
- correct typing for ApiError
- tighten values for responseType, responseMode
jaredperreault-okta
approved these changes
Apr 15, 2022
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Apr 15, 2022
OKTA-489428 <<<Jenkins Check-In of Tested SHA: 0d20151 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 32 PR Link: "#1184"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.