fix: AutoRenewService should perform renew if token has expired before service start #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denysoblohin-okta
requested review from
aarongranick-okta,
shuowu-okta and
jaredperreault-okta
| expect(client.tokenManager.renew).toHaveBeenCalledTimes(1); | ||
| expect(client.tokenManager.renew).toHaveBeenCalledWith('test-idToken'); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Can you add a test case which includes an expired token in the tokenManager before serviceManager.start is called?
|
Maybe |
Codecov ReportBase: 91.77% // Head: 91.79% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1354 +/- ##
==========================================
+ Coverage 91.77% 91.79% +0.02%
==========================================
Files 217 217
Lines 5206 5219 +13
Branches 1098 1100 +2
==========================================
+ Hits 4778 4791 +13
Misses 405 405
Partials 23 23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
denysoblohin-okta
force-pushed
the
od-renew-fix-OKTA-549676
branch
from
9fa72ee
to
66e049e
Compare
jaredperreault-okta
approved these changes
Dec 6, 2022
denysoblohin-okta
force-pushed
the
od-renew-fix-OKTA-549676
branch
from
cb36530
to
1d6bf59
Compare
…e service start .
denysoblohin-okta
force-pushed
the
od-renew-fix-OKTA-549676
branch
from
0551179
to
837f045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1164
Issue description:
Leader election can take some time,
AutoRenewServicewould not start until election is completed and current tab is a leader.If there is an expired token in storage on the moment
OktaAuthservice is started,TokenManagerwould emitEVENT_EXPIREDbutAutoRenewServicewould not catch/process this event because it's not started yet.Fix:
Process expired tokens on
AutoRenewServicestart.Internal ref: https://oktainc.atlassian.net/browse/OKTA-549676