fix: sameSite: use "lax" on HTTP #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongranick-okta
force-pushed
the
ag-fix-samesite-secure-OKTA-281382
branch
from
4cd032c
to
41a6f9c
Compare
swiftone
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with Chrome 80: https://blog.chromium.org/2020/02/samesite-cookie-changes-in-february.html
The main effect is that running within an iFrame is now only supported if the app is being hosted on a HTTPS protocol.
SameSite:Lax, unless running on HTTPS protocol, then cookies will useSameSite: None; SecureSameSite: Laxunless running on HTTPS protocol, then cookies will useSameSite: None; SecureSameSite: Laxunless thesecureoption is set to true, then it will useSameSite: None; SecureTokenManager is preserving existing opt-in behavior to avoid a breaking change. The scenario is that some customers may have an app running on mixed HTTPS and HTTP and they would like the tokens accessible in both contexts. This behavior is changing in 3.0: secure will be set by default, but there is an option to opt out.
I have tested locally using HTTPS proxy via https://ngrok.com/