chore: use server bundle for react native #363
Conversation
| @@ -13,8 +13,10 @@ | |||
| var AuthSdkError = require('./errors/AuthSdkError'); | |||
| var tx = require('./tx'); | |||
| var util = require('./util'); | |||
| var SDK_VERSION = require('../package.json').version; | |||
There was a problem hiding this comment.
If we require package.json during webpack we will end up with a lot of information in our webpack bundle which we don't want there. We should only require package.json if we are sure we are running server side. This file (builderUtil) is used by both webpack and server side code paths. Within webpack we have it set as a global variable. The node-side serverIndex could do something similar, read from package json and set as global variable.
There was a problem hiding this comment.
Gotcha, then I can pass SDK_VERSION as an argument in getUserAgent.
| } | ||
|
|
||
| if (userAgent.template) { | ||
| return userAgent.template.replace('$OKTA_AUTH_JS', `okta-auth-js/${SDK_VERSION}`); |
There was a problem hiding this comment.
here there is a forward slash separating okta-auth-js from SDK_VERSION but the default implementation (server.js, line 32 has no slash)
vijetmahabaleshwar-okta
force-pushed
the
sw-set-server-bundle-for-react-native-OKTA-289380
branch
from
7c7a179
to
68bbf34
Compare
shuowu-okta
force-pushed
the
sw-set-server-bundle-for-react-native-OKTA-289380
branch
from
f483cf7
to
dc3ccc0
Compare
Expose server bundle for React Native platform as an Authentication SDK.