compat fix: PKCE loadMeta will fallback to local storage #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftone
reviewed
Jun 12, 2020
| @@ -40,7 +40,8 @@ storageUtil.browserHasSessionStorage = function() { | |||
| }; | |||
|
|
|||
| storageUtil.getPKCEStorage = function(options) { | |||
| if (storageUtil.browserHasSessionStorage()) { | |||
| options = options || {}; | |||
| if (!options.preferLocalStorage && storageUtil.browserHasSessionStorage()) { | |||
swiftone
reviewed
Jun 12, 2020
packages/okta-auth-js/lib/pkce.js
Outdated
| // Verify the Meta | ||
| if (!obj.codeVerifier) { | ||
| // If meta is not valid, try reading from localStorage. | ||
| // This is for compatibility with older versions of the signin widget. |
There was a problem hiding this comment.
I'd love a Jira ticket reference here so someone could look up the specifics and know if the comment still applies.
swiftone
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error involving PKCE flow and the signin widget. In version 3.1.2 of
okta-auth-jsthe PKCE meta storage was changed to use sessionStorage. However, current and older versions of the signin widget which are bundled with an older version ofokta-auth-jswill store the PKCE meta in local storage. This will cause an error: The redirectUri passed to /authorize must also be passed to /token on callback. The underlying cause is that PKCE meta was not found in storage and an empty codeVerifier was passed to the/tokenendpoint.This PR adds logic to read from local storage if the meta cannot be found in session storage. This will provide compatibility for older versions of
okta-auth-jsincluding the bundled version within the signin widget.Additionally, this PR adds logic so that if the meta cannot be found in either session or local storage, an error will be thrown. This will avoid making a call to
/tokenwith an empty codeVerifier which causes the misleading error about "redirectUri"