Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: safari & firefox block getWithPopup issue #988

Conversation

shuowu
Copy link
Contributor

@shuowu shuowu commented Oct 26, 2021

Safari and Firefox block popup when they think the popup is not triggered by user interaction (when window.open is called asynchronous). This PR initials the popup window right after the user interaction, then update the redirect url when information is ready.

Tests:

  • Manually tested
  • Updated unit test
  • E2E - Saucelab tests should be re-enabled on bacon (OKTA-440989)

@shuowu shuowu marked this pull request as ready for review October 26, 2021 20:51
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (19cabc6) to head (bb10a0e).
Report is 356 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #988      +/-   ##
==========================================
- Coverage   92.30%   92.30%   -0.01%     
==========================================
  Files         121      121              
  Lines        3511     3510       -1     
  Branches      736      736              
==========================================
- Hits         3241     3240       -1     
  Misses        270      270              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shuowu-okta shuowu-okta force-pushed the sw-fix-safari-firefox-block-getWithPopup-issue-OKTA-426565 branch from f97f540 to bb10a0e Compare November 1, 2021 13:25
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Nov 1, 2021
OKTA-426565
<<<Jenkins Check-In of Tested SHA: bb10a0e for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 8
PR Link: "#988"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants