support RS384 and RS512 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@motocodeltd Many thanks for the PR! It would be great to have some unit tests on that. Can you do that? |
| return true | ||
| default: | ||
| return false | ||
| open class func hashFunction(_ alg: String) -> SignatureAlgorithm.HashFunction? { |
There was a problem hiding this comment.
Please, add comment
There was a problem hiding this comment.
this has now been done
|
@motocodeltd , thanks a lot for the contribution. Please sign CLA |
|
@oleggnidets-okta couple of unit tests added @IldarAbdullin-okta CLA emailed. thanks for the code! |
@motocodeltd We received the signed CLA. Thanks! |
oleggnidets-okta
approved these changes
Mar 22, 2021
|
@IldarAbdullin-okta @anastasiiaiurok-okta Please, approve or disapprove :) |
anastasiiaiurok-okta
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Analysis (Technical)
Okta JWT only supports RS256 - this adds support for RS384 and RS512.
Solution (Technical)
Change Utils.isSupportedAlg to Utils.hashFunction that returns the relevant function or nil. Function is passed in to RSAPKCS1VerifierFactory for verification.
Affected Components
Steps to reproduce:
Try to validate an RS384 or a RS512 token.
Actual result:
Fails with unsupported algorithm
Expected result:
Tests
Didn't commit any RS384 or RS512 tokens but could do if requested