Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Logout #7

Closed
jmelberg-okta opened this issue Jun 26, 2017 · 8 comments
Closed

Add support for Logout #7

jmelberg-okta opened this issue Jun 26, 2017 · 8 comments
Milestone

Comments

@jmelberg-okta
Copy link
Contributor

Pending the release of OKTA-94106 terminate the user's session with Okta.

@luksfarris
Copy link

Hi @jmelberg-okta, do you have any plans to add this feature?
I'd love to contribute with a pull request. I assume the effort here is fetching the logout URL from the openid config, and calling - (BOOL)presentAuthorizationWithURL:LOGOUT_URL session:nil from AppAuth

@jmelberg-okta
Copy link
Contributor Author

Hey @luksfarris! I'd love to be able to get this in before our 1.0 release in the next few months. If you'd like to help out, please shoot over a PR! I'd be happy to incorporate it.

@luksfarris
Copy link

Hi @jmelberg-okta , turns out it's harder than I expected 😅. I've created PR openid/AppAuth-iOS#191 for AppAuth, once it's merged I'll be able contribute here as well!

luksfarris pushed a commit to luksfarris/okta-sdk-appauth-ios that referenced this issue Jan 25, 2018
@luksfarris
Copy link

Hi @jmelberg-okta , the pull request I've created for AppAuth is moving forward, but more work will be needed in the future. Meanwhile, I've created a pull request for you that does the logout on our side, here it is #30 . I don't expect you to merge it soon, but at least this is something for us to start working with. It works for my okta setup

luksfarris pushed a commit to luksfarris/okta-sdk-appauth-ios that referenced this issue Feb 12, 2018
luksfarris pushed a commit to luksfarris/okta-sdk-appauth-ios that referenced this issue Feb 12, 2018
@ericraymond
Copy link

Hi @luksfarris,

I extracted logoutFlow from your commit and modified it to call it directly from my app (not part of the SDK).

I don't see any change in the logout behavior, the session still seems to be cached and the next login completes without any user interaction.

Any ideas on what I'm missing?

Thanks!

@andrewgotow
Copy link

Any progress on this?

I'm working on an enterprise application where users check out and share company devices, and official support for a log-out flow would be wonderful!

@omgitstom
Copy link

Thanks for your patience folks.

We are waiting on AppAuth (the underlying library that we use) to add this functionality:
openid/AppAuth-iOS#259

Once this is merged and released, we will be in the position to update the Okta library.

@nbarbettini nbarbettini mentioned this issue Oct 24, 2018
@robertjd robertjd added the to do label Nov 26, 2018
@nbarbettini nbarbettini added this to the 1.1.0 milestone Dec 4, 2018
@nbarbettini nbarbettini modified the milestones: 1.1.0, 2.0.0 Dec 13, 2018
@nbarbettini
Copy link

Closed via #103. We will be publishing a new version of this library soon with these changes, and the README has already been updated. If you need help with logout, let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants