Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

feat[oidc-middleware] Allow multiple instances of ExpressOIDC to co-exist #498

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

heidemn
Copy link

@heidemn heidemn commented Jul 19, 2019

…xist

The previous use of a static Passport instance prevented the parallel
use of multiple ExpressOIDC instances. Adding the Passport instance to
the context makes this possible.

Resolves: #497

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #497

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

…xist

The previous use of a static Passport instance prevented the parallel
use of multiple ExpressOIDC instances. Adding the Passport instance to
the context makes this possible.

Resolves: #497
@heidemn heidemn changed the title feat[oidc-middleware] Allow multiple instances of ExpressOIDC to co-e… feat[oidc-middleware] Allow multiple instances of ExpressOIDC to co-exist Jul 19, 2019
@peterhriser
Copy link

is this thing still alive. This is a pretty important change I think?

@heidemn
Copy link
Author

heidemn commented Jan 1, 2021

@peterhriser sorry for the late reply.
Feel free to continue this PR if needed. Our company no longer uses this package.

@ashermanwmf
Copy link

Hello, I work for Twitter and my team uses this package for our web app. We need this PR change to support our web apps auth strategy.

What are the next steps for this PR? Can it be reviewed/approved?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[oidc-middleware] It should be possible to use multiple instances of ExpressOIDC
4 participants