-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vuln libs #440
Merged
Merged
Update vuln libs #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajdeepnanua-okta
force-pushed
the
vulns_update
branch
5 times, most recently
from
December 16, 2024 20:10
12766cc
to
f0eabd3
Compare
rajdeepnanua-okta
force-pushed
the
vulns_update
branch
from
December 16, 2024 20:14
f0eabd3
to
8a4868c
Compare
Remove jsonpath plus
index.js
Outdated
@@ -54,12 +53,66 @@ class OktaStatusError extends Error { | |||
} | |||
} | |||
|
|||
class ConfigurationValidationError extends Error {} | |||
const findDomainURL = 'https://bit.ly/finding-okta-domain'; | |||
const findAppCredentialsURL = 'https://bit.ly/finding-okta-app-credentials'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const findAppCredentialsURL = 'https://bit.ly/finding-okta-app-credentials'; | |
const findAppCredentialsURL = 'https://developer.okta.com/docs/guides/find-your-app-credentials/'; |
mikenachbaur-okta
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates vuln libs and also removes jsonpath-plus. Thanks @vero1024 for jsonpath-plus removal :)
Additional changes in this PR are to update macos runner to macos 15 since the existing one (macos-12) is now deprecated by GHA.