feat: add generator submodule #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,63 @@ | |||
| /*! | |||
| * Copyright (c) 2015-2018, Okta, Inc. and/or its affiliates. All rights reserved. | |||
There was a problem hiding this comment.
nit: can extend banners script's files allowlist
oleksandrpravosudko-okta
approved these changes
Aug 27, 2021
shuowu-okta
force-pushed
the
sw-samples-generator
branch
from
fdf832a
to
6ad7fff
Compare
denysoblohin-okta
approved these changes
Aug 27, 2021
| To run this application, you first need to clone this repo: | ||
|
|
||
| ```bash | ||
| git clone https://github.com/okta/samples-js-react.git |
There was a problem hiding this comment.
Should new generated samples in this repo replace samples-js-react repo?
There was a problem hiding this comment.
It is the first step for samples auto-generation, in this PR, it grabs samples from the samples-js-react repo and developer docs, so in the future, when there is a change in the SDK repo, the PR should also update the generated samples at the same time, then downstream repos can just pull the latest changes without manual changes.
Co-authored-by: denysoblohin-okta <72614880+denysoblohin-okta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
generatedfolder)protractor(mostly brought from the okta-oidc-tck repo)