prep for auth-js 6.0 upgrade #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuowu
reviewed
Jan 11, 2022
src/Security.tsx
Outdated
| && process.env.SKIP_VERSION_CHECK !== '1') { | ||
| const err = new AuthSdkError(`Passed in oktaAuth is not compatible with the SDK, okta-auth-js version ${process.env.AUTH_JS_MAJOR_VERSION}.x is the current supported version.`); | ||
| return <OktaError error={err} />; | ||
| if (oktaAuth && oktaAuth._oktaUserAgent) { |
There was a problem hiding this comment.
This check will miss any version that does not have _oktaUserAgent (below 5.3.1). Maybe we can use a warn instead of throwing an error, so it won't break.
shuowu
approved these changes
Jan 11, 2022
src/Security.tsx
Outdated
| @@ -87,11 +83,22 @@ const Security: React.FC<{ | |||
| return <OktaError error={err} />; | |||
| } | |||
|
|
|||
| if (oktaAuthMajorVersion !== process.env.AUTH_JS_MAJOR_VERSION | |||
| if (oktaAuth) { | |||
There was a problem hiding this comment.
nit: oktaAuth is checked in line 76, no need to check it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Requires min version for
auth-jsof 5.3.1What is the current behavior?
Issue Number: OKTA-457552
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Reviewers