Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy #210 #213

Closed
wants to merge 3 commits into from
Closed

Copy #210 #213

wants to merge 3 commits into from

Conversation

shuowu-okta
Copy link
Contributor

@shuowu-okta shuowu-okta commented Feb 24, 2022 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy #210

Reviewers

jaredperreault-okta
jaredperreault-okta reviewed Feb 24, 2022
View reviewed changes
src/SecureRoute.tsx
if ('useRouteMatch' in ReactRouterDom) {
// trick static analyzer to avoid "'useRouteMatch' is not exported" error
// eslint-disable-next-line @typescript-eslint/no-explicit-any
useMatch = (ReactRouterDom as any)['useRouteMatch' in ReactRouterDom ? 'useRouteMatch' : ''];
Copy link
Contributor

@jaredperreault-okta jaredperreault-okta Feb 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be simplified to

  useMatch = (ReactRouterDom as any)['useRouteMatch'];

Line 21 already checks for the existence of useRouteMatch

eng-prod-CI-bot-okta pushed a commit that referenced this pull request Feb 24, 2022
@flying-sheep @eng-prod-CI-bot-okta
fix: avoid build time error when react-router-dom v6 is in app depe…
cf00f9d 
…ndencies

OKTA-472376
<<<Jenkins Check-In of Tested SHA: 53d64f2 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-react
Files changed count: 5
PR Link: "#213"
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Feb 24, 2022
@shuowu @eng-prod-CI-bot-okta
bump version to 6.4.3
9556afa 
OKTA-472376
<<<Jenkins Check-In of Tested SHA: 53d64f2 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-react
Files changed count: 5
PR Link: "#213"
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Feb 24, 2022
@shuowu @eng-prod-CI-bot-okta
lint
cd517c5 
OKTA-472376
<<<Jenkins Check-In of Tested SHA: 53d64f2 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-react
Files changed count: 5
PR Link: "#213"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredperreault-okta jaredperreault-okta jaredperreault-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shuowu-okta @jaredperreault-okta @eng-prod-CI-bot-2-okta @flying-sheep @shuowu