-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-7 upgrade #248
dev-7 upgrade #248
Conversation
scripts/setup.sh
Outdated
@@ -10,7 +10,7 @@ export PATH="${PATH}:$(yarn global bin)" | |||
|
|||
# Install required node version | |||
export NVM_DIR="/root/.nvm" | |||
NODE_VERSION="${1:-v12.20.0}" | |||
NODE_VERSION="${1:-v14.19.3}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the dependency that requires this specific min version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auth-js
jest.config.js
Outdated
@@ -25,7 +25,7 @@ module.exports = { | |||
], | |||
restoreMocks: true, | |||
moduleNameMapper: { | |||
'^@okta/okta-auth-js$': '<rootDir>/node_modules/@okta/okta-auth-js/dist/okta-auth-js.umd.js', | |||
// '^@okta/okta-auth-js$': '<rootDir>/node_modules/@okta/okta-auth-js/dist/okta-auth-js.umd.js', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove? or add comment explaining why it may be useful? (older authJS version?)
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Reviewers