-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support react-router 6 (#275) #282
base: master
Are you sure you want to change the base?
Conversation
OKTA-676780 Support react-router 6
Hi @jaredperreault-okta , is this PR going through your tests before being merged for a new okta-react version? |
@Spartan-Hex-Shadow Yes. This will become a new major version release |
Wonderful, thanks! |
@jaredperreault-okta any E.T.A on release? |
@Spartan-Hex-Shadow I apologize for the delay on this, however I am trying to determine what the best course of action for this SDK is. I'm curious, have you experimented with the use of |
Hi Jarred. We have not. Our app is heavily based around components and we have began the process of addressing technical debt by upgrading to the latest versions of our third party packages but cannot do so for some as this package does not support react router 6. The SecureOutlet approach would work very well for us and would be a seamless code transition from SecureRoute So we would personally prefer that but ultimately recognize it is not up to us to decide if that happens or not. |
OKTA-721854 merge master into dev7
Hi @jaredperreault-okta , any updates? |
@Spartan-Hex-Shadow Some other tasks have taken my attention. I'll be revisiting this soon |
@jaredperreault-okta Much appreciate, thank you so much. |
@jaredperreault-okta any updates? |
Any update on react-router 6 support? |
OKTA-676780 Support react-router 6
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Reviewers