Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use official generated Go file header #118

Closed
johanbrandhorst opened this issue Apr 7, 2020 · 1 comment
Closed

Use official generated Go file header #118

johanbrandhorst opened this issue Apr 7, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@johanbrandhorst
Copy link
Contributor

The format for a header that can identify any generated Go file was decided in golang/go#13560 (comment). The current generated files do not conform to this. We should change the generated code to output in this format.

I intend to submit a PR to fix this.
johanbrandhorst added a commit to johanbrandhorst/okta-sdk-golang that referenced this issue Apr 7, 2020
@johanbrandhorst
Change generated file header in line with Go standard
fdd43d5 
Fixes okta#118
@johanbrandhorst johanbrandhorst mentioned this issue Apr 7, 2020
Closed
@chrismorris-okta chrismorris-okta added the enhancement New feature or request label Apr 7, 2020
@bretterer
Copy link
Collaborator

Thanks for the information here. We will update our headers in the templates and release a new tag of the SDK

Internal Ref: OKTA-331907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change generated file header in line with Go standard johanbrandhorst/okta-sdk-golang
4 participants
@bretterer @johanbrandhorst @chrismorris-okta @bogdanprodan-okta