Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepping release #348

Merged
merged 4 commits into from
Nov 30, 2022
Merged

prepping release #348

merged 4 commits into from
Nov 30, 2022

Conversation

duytiennguyen-okta
Copy link
Contributor

Summary

Fixes #

Type of PR

  • Bug Fix (non-breaking fixes to existing functionality)
  • New Feature (non-breaking changes that add new functionality)
  • Documentation update
  • Test Updates
  • Other (Please describe the type)

Test Information

  • My PR required test updates

Go Version: 1.19
Os Version:
OpenAPI Spec Version: 3.0.0

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I ran make fmt on my code
  • I did not edit any automatically generated files

monde
monde requested changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@monde monde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err, I don't think we are ready to merge this into master

monde
monde approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@monde monde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 preparing build artifacts for v3 of the sdk

@duytiennguyen-okta duytiennguyen-okta merged commit b48d098 into master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monde monde monde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duytiennguyen-okta @monde