Skip to content

Commit

Permalink
Prepare for beta release (#356)
Browse files Browse the repository at this point in the history
* remove v2 methods from public client

* remove erroneous import statement

* list all breaking changes
  • Loading branch information
oleksandrpravosudko-okta authored Sep 7, 2022
1 parent 45a046b commit e228eab
Show file tree
Hide file tree
Showing 140 changed files with 385 additions and 691 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

### Other

- [#]() SDK methods are invoked through scoped API clients. Uses openapi-generator for creating SDK.
- [#]() Uses openapi-generator for creating SDK.

# 6.5.0

Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -982,8 +982,11 @@ const client: Client = new Client({

#### Breaking changes

- Methods are invoked on scoped clients
- Method params are passed as a single object
- Models no longer have CRUD methods
- Methods which return `Collection` become async
- Enums are replaced with union types

### From 5.x to 6.0

Expand Down
3 changes: 2 additions & 1 deletion scripts/emitV3Types.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ sed -i '' '/this.providerType =/d' ./src/generated/models/*.ts

# remove erroneous imports
sed -i '' '/^import { Set }/d' ./src/generated/models/*.ts
sed -i '' '/^import { URI }/d' ./src/generated/models/*.ts
sed -i '' '/^import { URI }/d' ./src/generated/**/*.ts


ignoredFiles=()

Expand Down
4 changes: 1 addition & 3 deletions src/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ const packageJson = require('../package.json');

const { ConfigLoader } = require('./config-loader');
const { DefaultRequestExecutor } = require('./default-request-executor');
const GeneratedApiClient = require('./generated-client');
const { Http } = require('./http');
const DEFAULT_USER_AGENT = `${packageJson.name}/${packageJson.version} node/${process.versions.node} ${os.platform()}/${os.release()}`;
const repoUrl = 'https://github.com/okta/okta-sdk-nodejs';
Expand Down Expand Up @@ -63,9 +62,8 @@ const { ServerConfiguration } = require('./generated/servers');
* @class Client
* @extends {GeneratedApiClient}
*/
class Client extends GeneratedApiClient {
class Client {
constructor(config) {
super();
const configLoader = new ConfigLoader();
const clientConfig = Object.assign({}, config);
configLoader.applyDefaults();
Expand Down
3 changes: 1 addition & 2 deletions src/types/client.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
* See the License for the specific language governing permissions and limitations under the License.
*/

import { ParameterizedOperationsClient } from './parameterized-operations-client';
import { OAuth } from './oauth';
import { Http } from './http';
import { RequestExecutor } from './request-executor';
Expand Down Expand Up @@ -48,7 +47,7 @@ import {
PushProviderApi,
DeviceAssuranceApi,
} from './generated';
export declare class Client extends ParameterizedOperationsClient {
export declare class Client {
constructor(config?: V2Configuration);

requestExecutor: RequestExecutor;
Expand Down
11 changes: 0 additions & 11 deletions src/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,5 @@ export * from './client';
export * from './request-executor';
export * from './default-request-executor';
export * from './collection';
export * from './parameterized-operations-client';
export * from './request-options/AutoLoginApplicationOptions';
export * from './request-options/BasicAuthApplicationOptions';
export * from './request-options/BookmarkApplicationOptions';
export * from './request-options/BrowserPluginApplicationOptions';
export * from './request-options/OpenIdConnectApplicationOptions';
export * from './request-options/SamlCustomApplicationOptions';
export * from './request-options/SecurePasswordStoreApplicationOptions';
export * from './request-options/SwaApplicationOptions';
export * from './request-options/SwaThreeFieldApplicationOptions';
export * from './request-options/WsFederationApplicationOptions';
export * from './generated';

41 changes: 0 additions & 41 deletions src/types/parameterized-operations-client.d.ts

This file was deleted.

60 changes: 0 additions & 60 deletions src/types/request-options/AutoLoginApplicationOptions.d.ts

This file was deleted.

28 changes: 0 additions & 28 deletions src/types/request-options/BasicAuthApplicationOptions.d.ts

This file was deleted.

28 changes: 0 additions & 28 deletions src/types/request-options/BookmarkApplicationOptions.d.ts

This file was deleted.

22 changes: 0 additions & 22 deletions src/types/request-options/BrowserPluginApplicationOptions.d.ts

This file was deleted.

57 changes: 0 additions & 57 deletions src/types/request-options/OpenIdConnectApplicationOptions.d.ts

This file was deleted.

62 changes: 0 additions & 62 deletions src/types/request-options/SamlCustomApplicationOptions.d.ts

This file was deleted.

Loading

0 comments on commit e228eab

Please sign in to comment.