Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @types dependencies should be devDependencies #281

Closed
wants to merge 1 commit into from

Conversation

loopingz
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

The @types/... dependencies are used for compilation and should not be added to runtime.
It can create conflict in this case @types/node-fetch is not useful anymore with node-fetch >= 3.0 (https://www.npmjs.com/package/node-fetch)

If you have a project using node-fetch >= 3.0 and having okta-sdk-nodejs as dependency it will prevent the project to build

What is the new behavior?

Move @types/... dependencies to devDependencies

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

@aarongranick-okta
Copy link
Contributor

@loopingz Thank you for this submission. I have requested a review from @oleksandrpravosudko-okta who is the primary maintainer of this SDK.

@oleksandrpravosudko-okta
Copy link
Contributor

Merged in 5834607

@loopingz
Copy link
Contributor Author

@aarongranick-okta thanks for the merge do you plan on release a new version soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants