fix: @types dependencies should be devDependencies #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
@types/...
dependencies are used for compilation and should not be added to runtime.It can create conflict in this case @types/node-fetch is not useful anymore with
node-fetch >= 3.0
(https://www.npmjs.com/package/node-fetch)If you have a project using
node-fetch >= 3.0
and havingokta-sdk-nodejs
as dependency it will prevent the project to buildWhat is the new behavior?
Move
@types/...
dependencies to devDependenciesDoes this PR introduce a breaking change?
Other information
Reviewers