Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate User Types API with swagger-codegen #305

Closed
wants to merge 27 commits into from
Closed

Generate User Types API with swagger-codegen #305

wants to merge 27 commits into from

Conversation

oleksandrpravosudko-okta
Copy link
Contributor

@oleksandrpravosudko-okta oleksandrpravosudko-okta commented Feb 23, 2022 •
edited
Loading

  • add swagger-codegen templates (axios is replaced with existing Http module)
  • place swagger-codegen output into v3 directories (both src and types)
  • generate v3 User Type API and model, add integration test
  • expose v3 via namespace through library root
  • add convenience script for converting TypeScript modules to Javascript + typings

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

@oleksandrpravosudko-okta oleksandrpravosudko-okta force-pushed the op-okta-453803-ots-user-type branch 5 times, most recently from cc5d9c4 to 4086b5b Compare March 9, 2022 15:18
@oleksandrpravosudko-okta oleksandrpravosudko-okta changed the base branch from oas-v3 to master March 9, 2022 15:22
@oleksandrpravosudko-okta oleksandrpravosudko-okta changed the base branch from master to oas-v3 March 9, 2022 15:22
@oleksandrpravosudko-okta oleksandrpravosudko-okta marked this pull request as ready for review March 9, 2022 15:46
@oleksandrpravosudko-okta
add swagger-codegen templates (typescript-axios)
ab8b853
@oleksandrpravosudko-okta
first pass on generating User Type API client
8220645
@oleksandrpravosudko-okta
fix v3 client return type
8853574
@oleksandrpravosudko-okta
include v3 models into index
ef102df
@oleksandrpravosudko-okta
add integration test for User Type API
27790a2
@oleksandrpravosudko-okta
rename apiKey -> apiToken
525c7c8
@oleksandrpravosudko-okta
add placeholder imports for type modules
ac9f03d
@oleksandrpravosudko-okta
add v3 typings
52f86a9
@oleksandrpravosudko-okta
replace TypeScript modules with JS + typings
eb24a96
@oleksandrpravosudko-okta
fix lint
c1a43db
@oleksandrpravosudko-okta
update template formatting
d3980ab
@oleksandrpravosudko-okta
add unused swagger-codegen output to gitignore
fb404a1
@oleksandrpravosudko-okta
add v3 APIs index module
a63ce8e
@oleksandrpravosudko-okta
add script for emitting V3 types
948c776
@oleksandrpravosudko-okta
fix lint errors
547deac
@oleksandrpravosudko-okta
do not expose v3 models through package root
16c6347
@oleksandrpravosudko-okta
expose v2 models
e36d184
@oleksandrpravosudko-okta
add instructions for generating SDK with swagger-codegen
7e7341a
@oleksandrpravosudko-okta
remove merge artifacts
ee32e21
@oleksandrpravosudko-okta
fix eslint error
8fcc26c
@oleksandrpravosudko-okta
correct import case
7d7c239
@oleksandrpravosudko-okta oleksandrpravosudko-okta force-pushed the op-okta-453803-ots-user-type branch from bfae528 to 42fcfb8 Compare March 15, 2022 16:11
@oleksandrpravosudko-okta oleksandrpravosudko-okta changed the base branch from oas-v3 to master March 15, 2022 16:40
@oleksandrpravosudko-okta oleksandrpravosudko-okta changed the base branch from master to oas-v3 March 15, 2022 16:40
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Mar 15, 2022
@oleksandrpravosudko-okta @eng-prod-CI-bot-okta
feat: add User Type API (generated by swagger-codegen)
4bf219e 
OKTA-453803
<<<Jenkins Check-In of Tested SHA: 42fcfb8 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-sdk-nodejs
Files changed count: 41
PR Link: "#305"
oleksandrpravosudko-okta added a commit that referenced this pull request Mar 31, 2022
@oleksandrpravosudko-okta
feat: add User Type API (generated by swagger-codegen)
f6a1c09 
OKTA-453803
<<<Jenkins Check-In of Tested SHA: 42fcfb8 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-sdk-nodejs
Files changed count: 41
PR Link: "#305"
oleksandrpravosudko-okta added a commit that referenced this pull request May 30, 2022
@oleksandrpravosudko-okta
feat: add User Type API (generated by swagger-codegen)
40221ee 
OKTA-453803
<<<Jenkins Check-In of Tested SHA: 42fcfb8 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-sdk-nodejs
Files changed count: 41
PR Link: "#305"
oleksandrpravosudko-okta added a commit that referenced this pull request May 30, 2022
@oleksandrpravosudko-okta
feat: add User Type API (generated by swagger-codegen)
4365cdb 
OKTA-453803
<<<Jenkins Check-In of Tested SHA: 42fcfb8 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-sdk-nodejs
Files changed count: 41
PR Link: "#305"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuowu-okta shuowu-okta shuowu-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandrpravosudko-okta @shuowu-okta @eng-prod-CI-bot-okta