Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate User Type API into v2 Client #310

Closed
wants to merge 26 commits into from
Closed

Integrate User Type API into v2 Client #310

wants to merge 26 commits into from

Conversation

oleksandrpravosudko-okta
Copy link
Contributor

@oleksandrpravosudko-okta oleksandrpravosudko-okta commented Mar 16, 2022 •
edited
Loading

OKTA-453803

  • call v3 User Type API methods from v2 client (no v2 interface changes)
  • integration test for calling v3 User Type API as standalone module and through v2 client
  • aux changes:
    • convert existing JS modules to use named exports to match typings
    • emit more precise v3 typings (provide required base typings for tsc run)

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

@oleksandrpravosudko-okta oleksandrpravosudko-okta changed the base branch from master to oas-v3 March 16, 2022 15:57
@oleksandrpravosudko-okta
switch to named exports for existing JS modules
21c42e7 
* so that can be matched against typing modules used during TS compilation of v3 modules
@oleksandrpravosudko-okta
update import syntax to ES for API template
2f5b2d9
@oleksandrpravosudko-okta
correct variable names and more of import updates
a6c506c
@oleksandrpravosudko-okta
used named imports in emitted code
6a9c012
@oleksandrpravosudko-okta
more of named export syntax updates
df46362
@oleksandrpravosudko-okta
add missing type import
6139f87
@oleksandrpravosudko-okta
update template indents
145d45e
@oleksandrpravosudko-okta
update rsync command
180a9e6
@oleksandrpravosudko-okta
copy common typings before tsc run
ca55027
@oleksandrpravosudko-okta
use named exports in v2 client
061d20b
@oleksandrpravosudko-okta
include v3 API into v2 templates
8d66ada
@oleksandrpravosudko-okta
use http client instance in API class, remove types unnecessary for t…
40719ef 
…sc compilation
@oleksandrpravosudko-okta
drop support for async request args builders
0250f2a
@oleksandrpravosudko-okta
enable integration tests for User Type API
3c86965
@oleksandrpravosudko-okta
correct module path
0c268e8
@oleksandrpravosudko-okta
fix import syntax in unit tests
e0d23ac
@oleksandrpravosudko-okta
fix imports in jest tests
2544377
@oleksandrpravosudko-okta
fix lint
ce25f9e
@oleksandrpravosudko-okta oleksandrpravosudko-okta changed the title Op okta 453803 user type bridge layer Integrate User Type API into v2 Client Mar 23, 2022
@oleksandrpravosudko-okta oleksandrpravosudko-okta marked this pull request as ready for review March 23, 2022 14:18
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Mar 25, 2022
@oleksandrpravosudko-okta @eng-prod-CI-bot-okta
integrate UserType API into v2 Client
0384931 
OKTA-453803
<<<Jenkins Check-In of Tested SHA: 3b8b3d1 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-sdk-nodejs
Files changed count: 43
PR Link: "#310"
oleksandrpravosudko-okta added a commit that referenced this pull request Mar 31, 2022
@oleksandrpravosudko-okta
integrate UserType API into v2 Client
8e7ca0e 
OKTA-453803
<<<Jenkins Check-In of Tested SHA: 3b8b3d1 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-sdk-nodejs
Files changed count: 43
PR Link: "#310"
oleksandrpravosudko-okta added a commit that referenced this pull request May 30, 2022
@oleksandrpravosudko-okta
integrate UserType API into v2 Client
52be5b7 
OKTA-453803
<<<Jenkins Check-In of Tested SHA: 3b8b3d1 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-sdk-nodejs
Files changed count: 43
PR Link: "#310"
oleksandrpravosudko-okta added a commit that referenced this pull request May 30, 2022
@oleksandrpravosudko-okta
integrate UserType API into v2 Client
b305cf4 
OKTA-453803
<<<Jenkins Check-In of Tested SHA: 3b8b3d1 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-sdk-nodejs
Files changed count: 43
PR Link: "#310"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuowu shuowu shuowu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandrpravosudko-okta @shuowu @eng-prod-CI-bot-okta