Integrate Authenticator API into v2 Client #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandrpravosudko-okta
changed the title
oleksandrpravosudko-okta
force-pushed
the
op-okta-453756-authenticator-api-v3
branch
from
a15ab31 to
40ce7f8
Compare
shuowu
reviewed
Mar 28, 2022
| it('should deactivate an active Authenticator', async () => { | ||
| const authenticators = await client.listAuthenticators(); // returns Collection<Authenticator> | ||
| // OKTA-483353 | ||
| xit('should deactivate an active Authenticator', async () => { |
There was a problem hiding this comment.
maybe some MFA enrollment policy are not cleared after test.
There was a problem hiding this comment.
this appears to be an issue even in isolated run (running only this test for the first time after policy reset succeeds, but all subsequent runs fail)
| @@ -1,44 +0,0 @@ | |||
| import * as okta from '@okta/okta-sdk-nodejs'; | |||
There was a problem hiding this comment.
duplicate with the deactivate one?
There was a problem hiding this comment.
yes, they have same steps
| @@ -4,7 +4,7 @@ import { | |||
| DefaultRequestExecutor, | |||
| UserSchema, | |||
| UserSchemaDefinitions, | |||
| UserType } from '@okta/okta-sdk-nodejs'; | |||
| v3 } from '@okta/okta-sdk-nodejs'; | |||
There was a problem hiding this comment.
Is this just a temp solution, and we will do a final swap when everything is ready?
There was a problem hiding this comment.
yes; the swap will be a breaking change though since v2 and v3 models are not compatible (v3 doesn't have CRUD)
shuowu-okta
approved these changes
Mar 28, 2022
shuowu
approved these changes
Mar 28, 2022
oleksandrpravosudko-okta
added a commit
that referenced
this pull request
Mar 31, 2022
integrate Authenticator API into v2 client
oleksandrpravosudko-okta
added a commit
that referenced
this pull request
May 30, 2022
integrate Authenticator API into v2 client
oleksandrpravosudko-okta
added a commit
that referenced
this pull request
May 30, 2022
integrate Authenticator API into v2 client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-453756, OKTA-453757
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Reviewers