Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filter and pagination integration tests #348

Merged
merged 19 commits into from
Jul 15, 2022

Conversation

denysoblohin-okta
Copy link
Contributor

@denysoblohin-okta denysoblohin-okta commented Jul 12, 2022

Internal ref: OKTA-512396

  • Added filter and pagination integration tests
  • Added yarn validate:v2-v3 to catch v2 vs v3 specs incompatibility.

Found issues:

  • listIdentityProviders - type and q does not work (server issue)
  • listUsers - using q produces error (query params incompatibility in v2 vs v3 specs)
  • listGroups - using search and limit produces error (query params incompatibility in v2 vs v3 specs)
  • listApplications - includeNonDeleted has no effect (spec issue)
  • listAuthorizationServers - limit should be number, not string (spec issue)
  • listOrigins - pagination with q works incorrectly, q is replaced with filter in next link (server issue)
  • listOAuth2Scopes - filter, limit, after does not work and not documented (spec issue?)

(follow-up OKTA-515269)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
.
.
@denysoblohin-okta denysoblohin-okta changed the base branch from master to oas-v3-openapi-generator July 12, 2022 11:09
@denysoblohin-okta denysoblohin-okta changed the title Od pagination okta 512396 Added filter and pagination integration tests Jul 14, 2022
@denysoblohin-okta denysoblohin-okta marked this pull request as ready for review July 14, 2022 10:58
@denysoblohin-okta denysoblohin-okta merged commit 41be7fb into oas-v3-openapi-generator Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants