-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added filter and pagination integration tests #348
Merged
denysoblohin-okta
merged 19 commits into
oas-v3-openapi-generator
from
od-pagination-OKTA-512396
Jul 15, 2022
Merged
Added filter and pagination integration tests #348
denysoblohin-okta
merged 19 commits into
oas-v3-openapi-generator
from
od-pagination-OKTA-512396
Jul 15, 2022
+883
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denysoblohin-okta
changed the base branch from
master
to
oas-v3-openapi-generator
July 12, 2022 11:09
denysoblohin-okta
changed the title
Od pagination okta 512396
Added filter and pagination integration tests
Jul 14, 2022
oprav
approved these changes
Jul 15, 2022
oleksandrpravosudko-okta
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal ref: OKTA-512396
yarn validate:v2-v3
to catch v2 vs v3 specs incompatibility.Found issues:
listIdentityProviders
-type
andq
does not work (server issue)listUsers
- usingq
produces error (query params incompatibility in v2 vs v3 specs)listGroups
- usingsearch
andlimit
produces error (query params incompatibility in v2 vs v3 specs)listApplications
-includeNonDeleted
has no effect (spec issue)listAuthorizationServers
-limit
should be number, not string (spec issue)listOrigins
- pagination withq
works incorrectly,q
is replaced withfilter
innext
link (server issue)listOAuth2Scopes
-filter
,limit
,after
does not work and not documented (spec issue?)(follow-up OKTA-515269)