-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Readme and default config file to clarify what the Org URL i… #28
base: master
Are you sure you want to change the base?
Conversation
…s and where to find it (this tripped me up during app creation.
|
||
Now place these values into the file `src/.samples.config.js` that was created for you in this project: | ||
|
||
```javascript | ||
export default { | ||
oidc: { | ||
clientId: '{clientId}', | ||
issuer: 'https://{yourOktaDomain}.com/oauth2/default', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value you deleted is the standard syntax we use to specify this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any ideas to provide clarity for new devs on the difference between Okta Domain, dev console domain, and Org URL? I pasted my dev console domain and got a 404.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add a note like this:
TIP: The value of {yourOktaDomain}
should be something like dev-123456.oktapreview
. Make sure you don't include -admin
in the value!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that (although it wouldn't have helped me since I didn't read the comments before filling in the values.) Would it also make sense to change the "Org URL" in the dashboard to "Your Okta Domain" for clarity?
Yes, I think this would help.
… On Mar 16, 2018, at 17:31, Dave Nugent ***@***.***> wrote:
@drnugent commented on this pull request.
In custom-login/README.md:
>
Now place these values into the file `src/.samples.config.js` that was created for you in this project:
```javascript
export default {
oidc: {
clientId: '{clientId}',
- issuer: 'https://{yourOktaDomain}.com/oauth2/default',
I can do that (although it wouldn't have helped me since I didn't read the comments before filling in the values.) Would it also make sense to change the "Org URL" in the dashboard to "Your Okta Domain" for clarity?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
when i run npm install .samples.config.j is created by default. may i know the background of this? how is that happening? |
…s and where to find it (this tripped me up during app creation.