Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing okta_rate_limiting causes crash #909

Closed
jamesathey opened this issue Jan 14, 2022 · 2 comments
Closed

Importing okta_rate_limiting causes crash #909

jamesathey opened this issue Jan 14, 2022 · 2 comments
Assignees

Comments

@jamesathey
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v1.1.3
on darwin_amd64
+ provider registry.terraform.io/okta/okta v3.20.3

Affected Resource(s)

  • okta_rate_limiting

Terraform Configuration Files

terraform {
  required_providers {
    okta = {
      source = "okta/okta"
      version = "~> 3.20"
    }
  }
}

# Configure the Okta Provider
provider "okta" {
    org_name  = "<removed for security reasons>"
    base_url  = "okta.com"
    api_token = "<removed for security reasons>"
}

resource "okta_rate_limiting" "client_based_rate_limiting" {
  login                  = "PREVIEW"
  authorize              = "PREVIEW"
  communications_enabled = true
}

Debug Output

Debug Output gist

Panic Output

crash.log

Expected Behavior

The docs for okta_rate_limiting state:

Rate limit settings can be imported without any parameters.

$ terraform import okta_rate_limiting.example .

That is what I was attempting to do for an existing Okta instance that I want to manage with terraform.

Actual Behavior

The plugin crashed.

Steps to Reproduce

  1. Define an okta_rate_limiting resource in a terraform file.
  2. terraform import okta_rate_limiting.(name of resource) .

Important Factoids

References

@monde
Copy link
Collaborator

monde commented Jan 28, 2022

Thanks @jamesathey - I've opened a PR to put a nil bumper there to prevent a panic.

@monde
Copy link
Collaborator

monde commented Feb 7, 2022

Fixed and release in #929

@monde monde closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants