-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing valid custom role permissions #1023
Conversation
Thanks for your patience with my first PR in the That said, if I'm missing anything, please let me know, and I'll do my best to add it 🙏🏼 |
Thank you @lucascantor ! |
@monde I see I need approval before 1 workflow will run, as I'm a first-time contributor: |
Hi @lucascantor , apologies for my slowness. Can you make strings in the I think the workflow will fail when when we have it run on your cloned repo. I'll have to double check after the change, and might have to start a new branch and cherry pick in your commits. |
@monde not a problem at all. I sincerely appreciate the help. I believe I've made the change you're looking for now 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will be easy to see changes in the future, thank you @lucascantor
I'll get this into the next release @lucascantor , thank you! |
@lucascantor this is released as v3.23.0 |
@monde I noticed and we're already using it - thanks so much! |
Valid permissions are documented at https://developer.okta.com/docs/reference/api/roles/#permission-properties