Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default auth server id when activate/deactivate it #1045

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

peijiinsg
Copy link
Contributor

This PR is to fix the issue: #1043
When activate/deactivate default auth server, the id is not fetched properly which results an invalid POST url constructed.

@monde monde self-requested a review April 6, 2022 16:47
Copy link
Collaborator

@monde monde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I see the logical error if id is set by name id = d.Get("name").(string) but later represented by d.Id() which could be blank.

@peijiinsg
Copy link
Contributor Author

Looks good, I see the logical error if id is set by name id = d.Get("name").(string) but later represented by d.Id() which could be blank.

yeah, I got the blank value when trying to deactivating the auth server, which result the error.

@peijiinsg peijiinsg deleted the fix-default-auth-server branch April 7, 2022 23:46
@monde
Copy link
Collaborator

monde commented Apr 8, 2022

@peijiinsg this is released as v3.23.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants