Allow configuring a custom endpoint #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monde
reviewed
Jun 1, 2022
monde
reviewed
Jun 1, 2022
|
@ido50 let me know what you think my suggestion of |
|
Signed and sent CLA. Thanks. |
monde
reviewed
Jun 1, 2022
okta/config.go
Outdated
| @@ -33,6 +34,7 @@ type ( | |||
| Config struct { | |||
| orgName string | |||
| domain string | |||
| customEndpoint string | |||
There was a problem hiding this comment.
Asking for name customEndpoint be named httpProxy per the main discussion on the PR.
There was a problem hiding this comment.
Also updated the commit message to reflect these changes.
The ability to configure a proxy URL endpoint for the Okta API is added to the provider. This is useful for unit testing or running local caching proxies. A new configuration option called "http_proxy" is added, which by default takes the value of the "OKTA_HTTP_PROXY" environment variable. When used, and if the provided endpoint is an HTTP endpoint (rather than an HTTPS endpoint), the HTTPS check is automatically disabled. A unit test called `TestHTTPProxy` is added which also showcases unit testing of the Okta API without actually contacting Okta. Information about the new configuration option is also added to the documentation.
monde
approved these changes
Jun 1, 2022
|
@ido50 this will be released in 3.29.0 either tomorrow or Friday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to configure a custom URL endpoint for the Okta API is added
to the provider. This is useful for unit testing or running local
caching proxies.
A new configuration option called "custom_endpoint" is added, which by
default takes the value of the "OKTA_CUSTOM_ENDPOINT" environment
variable. When used, and if the provided endpoint is an HTTP endpoint
(rather than an HTTPS endpoint), the HTTPS check is automatically
disabled.
A unit test called
TestCustomEndpointis added which also showcasesunit testing of the Okta API without actually contacting Okta.
Information about the new configuration option is also added to the
documentation.