Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS okta_user and okta_users bug fixes and improvements #1159

Merged
merged 3 commits into from
Jun 9, 2022
Merged

DS okta_user and okta_users bug fixes and improvements #1159

merged 3 commits into from
Jun 9, 2022

Conversation

monde
Copy link
Collaborator

@monde monde commented Jun 8, 2022 •
edited
Loading

  • Improve ds okta_user documentation
  • Improve ds okta_users documentation
  • Add additional skip roles, skip groups tests to ds okta_user
  • Add delay_read_seconds property to ds okta_user
  • Add delay_read_seconds property to ds okta_users
  • Add include_roles property to ds okta_users
  • Fixed bug where ds okta_users was not including admin roles

monde added 2 commits June 8, 2022 15:32
@monde
Adding delay_read_seconds to DS okta_user. Added addtional tests to…
e5920a2 
… DS okta_user including some output examples.
@monde
Fix bug where DS okta_users wasn't including admin roles. Add property
ba654ff 
include_roles to signal admin roles should be fetched for each user.
Added delay_read_seconds property. Complete test coverage for
include_roles and include_groups combinations.
@monde monde changed the title Verbose documentnation on DS okta_user and additional tests. DS okta_user and okta_users bug fixes and improvements Jun 8, 2022
This was referenced Jun 8, 2022
Closed
Closed
@monde monde merged commit 8380385 into master Jun 9, 2022
@monde monde deleted the exitcode0_data_okta_user branch June 9, 2022 20:35
@monde
Copy link
Collaborator Author

monde commented Jun 10, 2022

Released https://github.com/okta/terraform-provider-okta/releases/tag/v3.29.0

@smistephenresmed smistephenresmed mentioned this pull request Jul 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijetmahabaleshwar-okta vijetmahabaleshwar-okta vijetmahabaleshwar-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monde @vijetmahabaleshwar-okta