Syncing accepted oauth api scopes with documented options #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @awagneratzendesk I'd love to get rid of the provider validator that uses that resource, the API already does input validation. I think we are doing such in v4 |
monde
requested changes
Mar 17, 2023
|
@monde Sorry about that, was a copy/paste error from moving to my forked repo instead of the main one. Fixed now! |
monde
approved these changes
Mar 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #1493 and syncs the validScopes for oauth api scopes with the options available in the Okta documentation available here
This was tested locally to validate that the additional scopes can be successfully applied to an okta_app_oauth_api_scope resource.
Tests pass successfully and I don't think this requires any additional documentation updates.