remove deprecated resource and datasource #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duytiennguyen-okta
force-pushed
the
OKTA-592057-remove-deprecated-resource
branch
from
2279216
to
f087319
Compare
monde
approved these changes
Apr 19, 2023
| @@ -7,6 +7,7 @@ import ( | |||
| "github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource" | |||
| ) | |||
|
|
|||
| // TODU | |||
There was a problem hiding this comment.
Is there still a TODO here?
| @@ -15,6 +15,7 @@ import ( | |||
| "github.com/hashicorp/terraform-plugin-sdk/v2/terraform" | |||
| ) | |||
|
|
|||
| // TODU | |||
|
Super excited about removing all the cruft! |
|
Hey @duytiennguyen-okta Any info on when we can expect a 4.x release? Would be happy to test. |
|
@virgofx It should be release by the end of the week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove deprecated resource and data source as noted in #1338
I also removed some of attribute that was removed in the resource but not the data source (data_source_okta_user.go)
These 2 test still fail
TestAccOktaPolicyRuleIdpDiscovery_crudandTestAccOktaUser_customProfileAttributes