enable custom OTP on okta_authenticator #1864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duytiennguyen-okta
requested changes
Jan 31, 2024
okta/resource_okta_authenticator.go
Outdated
| @@ -263,7 +287,9 @@ func buildAuthenticator(d *schema.ResourceData) (*sdk.Authenticator, error) { | |||
| Key: d.Get("key").(string), | |||
| Name: d.Get("name").(string), | |||
| } | |||
| if d.Get("type").(string) == "security_key" { | |||
| if d.Get("key").(string) == "custom_otp" { | |||
|
|
|||
There was a problem hiding this comment.
Empty if statement
| @@ -150,15 +150,9 @@ func findAuthenticator(ctx context.Context, m interface{}, name, key string) (*s | |||
| return nil, err | |||
| } | |||
| for _, authenticator := range authenticators { | |||
| if authenticator.Name == name { | |||
| if authenticator.Name == name && authenticator.Key == key { | |||
There was a problem hiding this comment.
This will cause breaking change
| @@ -31,9 +31,6 @@ func resourceAuthenticator() *schema.Resource { | |||
| Type: schema.TypeString, | |||
| Required: true, | |||
| Description: "Display name of the Authenticator", | |||
| DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool { | |||
There was a problem hiding this comment.
Why do you need to remove this?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This pull request introduces Custom OTP functionality to the Okta provider in Terraform. It also addresses an issue where the correct authenticator was not being selected due to the absence of a specified name.
Technical Details