Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: DataSource okta_apps #1967

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

exitcode0
Copy link
Contributor

@exitcode0 exitcode0 commented Apr 15, 2024

I've cherry picked an existing PR and had a crack at implementing this with the terraform provider framework
I'm still pretty clueless with GoLang and would love feedback so I can tweak this as needed

I had some trouble trying to get additional information to work with the dataSource, things like the appSettings, appVisibility, appCredentials - I couldn't figure out how to go about creating an interface for these types, i'd love some guidance on this if possible

@exitcode0 exitcode0 force-pushed the datasource_okta_apps branch 2 times, most recently from e7c5d1b to e4fe032 Compare September 9, 2024 06:18
@exitcode0 exitcode0 changed the title Cherry-pick #1816 - Add apps data source, docs, & acceptance test. Feat: DataSource okta_apps Sep 9, 2024
@exitcode0
Copy link
Contributor Author

@duytiennguyen-okta any chance I could trouble you for a code review on this one?
i'd love some guidance on how I should've gone about constructing interfaces for these applications or if i've gone about this in the wrong way

@monde monde assigned monde and arvindkrishnakumar-okta and unassigned monde Sep 11, 2024
@exitcode0 exitcode0 force-pushed the datasource_okta_apps branch 4 times, most recently from 207c81b to 5462d93 Compare November 7, 2024 05:17
@duytiennguyen-okta
Copy link
Contributor

duytiennguyen-okta commented Nov 8, 2024

@exitcode0 hey nice works. The apps seems to works fine and got all the fields you need it seems. Before approval, I just want to know if there is no parameter provider, okta_apps will return all apps? Is that your intention?
data "okta_apps" "test" { }
Also do you want to bring appSettings, appVisibility and appCredentials in still? I can give you an example if you wish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants