Fix okta_app_* unable to import authentication policy #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exitcode0
reviewed
May 21, 2024
| @@ -40,6 +40,7 @@ other arguments that changed will be applied.`, | |||
| "authentication_policy": { | |||
| Type: schema.TypeString, | |||
| Optional: true, | |||
| Computed: true, | |||
There was a problem hiding this comment.
I don't have confidence in my knowledge of TF provider schemas and their behaviours
Will setting Computed: true here prevent the user from specifying or updating the authentication policy on a given okta_app_*?
There was a problem hiding this comment.
No. It will allow the provider to set the authentication_policy to default if it is not specified. I want to deprecate authentication_policy, but it will have to be major version change
duytiennguyen-okta
force-pushed
the
OKTA-718924-fix-authentication-policy-okta-app
branch
from
5d4a9e1
to
1ed37eb
Compare
Signed-off-by: Tien Nguyen <duytien.nguyen@okta.com> Signed-off-by: Tien Nguyen <duytien.nguyen@okta.com>
duytiennguyen-okta
force-pushed
the
OKTA-718924-fix-authentication-policy-okta-app
branch
from
1ed37eb
to
2c99ad1
Compare
Signed-off-by: Tien Nguyen <duytien.nguyen@okta.com>
monde
approved these changes
May 22, 2024
duytiennguyen-okta
deleted the
OKTA-718924-fix-authentication-policy-okta-app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1942
Close #1742