Improve limit implementation on data_okta_groups
#2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by passing the limit parameter in from the schema, the user has control over when they would like to return a higher number of groups
exitcode0
changed the title
limit implementation on data_source_okta_groupslimit implementation on data_okta_groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously only allowing for the use of a higher
limitif theqparameter was usedThis new implementation should allow the user to override the default page size when they need to
This should also improve the response time for queries that were seeking a small number of groups using the
qparameter as the okta api returns results faster when the default page size is used