Skip to content

Add Basic Realm Support #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tim-koehler
Copy link
Contributor

With this PR basic realm support is added which allows the use of the okta_realm resource:

resource "okta_realm" "example" {
  name       = "Example Realm"
  realm_type = "DEFAULT"
}

as well as the data-source:

data "okta_realm" "example" {
  name       = "Example Realm"
  # or
  id         = "<some-realm-id>
}

This is the first step towards closing #2242.

Looking forward to receive some feedback 😊

@tim-koehler tim-koehler marked this pull request as ready for review April 23, 2025 16:43
@tim-koehler tim-koehler force-pushed the realm-support-#2242 branch 2 times, most recently from 9a00a2b to 0dd9ade Compare April 29, 2025 10:50
@tim-koehler
Copy link
Contributor Author

  • CLA signed and mailed
  • Implemented with the Terraform Plugin Framework
  • Okta API calls are performed with the okta-sdk-golang v5
  • Passing Acceptance Tests included

@duytiennguyen-okta I don't know if you are the right person to ask but when can I expect a review from the maintainers?

Thanks a lot
Tim

@tim-koehler tim-koehler force-pushed the realm-support-#2242 branch 3 times, most recently from 1b7b571 to aaaf13c Compare May 2, 2025 09:09
@tim-koehler
Copy link
Contributor Author

After this PR has been merged there is another follow-up pull request which introduces the okta_realm_assignment resource and data-source.
#2293

@tim-koehler tim-koehler force-pushed the realm-support-#2242 branch from aaaf13c to 7929efd Compare May 13, 2025 11:47
@tim-koehler
Copy link
Contributor Author

The following adjustments according to the linters suggestion have been implemented:
R018: prefer resource.Retry() or (resource.StateChangeConf).WaitForState() over time.Sleep()

make qc passed now locally

@manmohan-shaw-okta
Please trigger the workflow again.
Thanks 😊

@tim-koehler tim-koehler force-pushed the realm-support-#2242 branch 2 times, most recently from 61b409f to f589b0c Compare May 16, 2025 07:43
@tim-koehler
Copy link
Contributor Author

@manmohan-shaw-okta
Added the verified signature. Should be good to go now 🚀
Also for #2293

@exitcode0
Copy link
Contributor

Hey @tim-koehler,
It looks like this PR has some merge conflicts now that V5 has been released, did you want to rebase this one?

@tim-koehler tim-koehler force-pushed the realm-support-#2242 branch from f589b0c to 21a0f1e Compare July 1, 2025 11:19
@tim-koehler
Copy link
Contributor Author

Hey @exitcode0
I have rebased and adjusted to the v5 changes. Please have a look and go ahead.
Thanks.

@tim-koehler
Copy link
Contributor Author

Hey @aditya-okta
we really need this feature to be implemented.

Is it possible to merge that into v5 or will it be part of v6?
If that is the case, when can we expect v6 to be released?

@aditya-okta
Copy link
Contributor

@tim-koehler , can you record the VCR test for these resources?

@tim-koehler tim-koehler force-pushed the realm-support-#2242 branch from ccaed75 to aed1889 Compare August 7, 2025 11:03
@tim-koehler
Copy link
Contributor Author

Hey @aditya-okta & @pranav-okta,
I have recorded and added the VCR tests

@tim-koehler
Copy link
Contributor Author

This PR can be closed since #2293 has been merged which includes these changes

@tim-koehler tim-koehler closed this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants