-
Notifications
You must be signed in to change notification settings - Fork 232
Add Basic Realm Support #2287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Basic Realm Support #2287
Conversation
9a00a2b
to
0dd9ade
Compare
@duytiennguyen-okta I don't know if you are the right person to ask but when can I expect a review from the maintainers? Thanks a lot |
1b7b571
to
aaaf13c
Compare
After this PR has been merged there is another follow-up pull request which introduces the |
aaaf13c
to
7929efd
Compare
The following adjustments according to the linters suggestion have been implemented:
@manmohan-shaw-okta |
61b409f
to
f589b0c
Compare
@manmohan-shaw-okta |
Hey @tim-koehler, |
f589b0c
to
21a0f1e
Compare
Hey @exitcode0 |
21a0f1e
to
ccaed75
Compare
Hey @aditya-okta Is it possible to merge that into v5 or will it be part of v6? |
@tim-koehler , can you record the VCR test for these resources? |
ccaed75
to
aed1889
Compare
Hey @aditya-okta & @pranav-okta, |
This PR can be closed since #2293 has been merged which includes these changes |
With this PR basic realm support is added which allows the use of the
okta_realm
resource:as well as the data-source:
This is the first step towards closing #2242.
Looking forward to receive some feedback 😊