Validate credentials in provider configure func #579
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds credential validation when the provider's configuration function is called during initialization. It calls
/api/v1/users/me
and returns an error when it fails, which will prevent further execution of the provider. This seems like the only API route that should be accessible regardless of administrative roles assigned to the calling user.When using an invalid token:
This provides some assurance that the credentials are valid without causing a single failing request to crash the plugin and halt other
okta_*
resources, for which the credentials may be valid.data.okta_user
: plugin crashes on expected 403 errors #577