Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML SLO Cert Fix #923

Closed
wants to merge 2 commits into from
Closed

SAML SLO Cert Fix #923

wants to merge 2 commits into from

Conversation

ymylei
Copy link
Contributor

@ymylei ymylei commented Jan 25, 2022

If you upload an invalid cert, you can populate these other fields but the certificate field will be null. This check avoids a provider crash when this scenario appears and a refresh happens.

@ymylei
Copy link
Contributor Author

ymylei commented Jan 25, 2022

Test results:

➜  terraform-provider-okta git:(saml-fix) TEST_FILTER=TestAccAppSaml_crud make testacc
go mod tidy
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -run TestAccAppSaml_crud -timeout 120m
?       github.com/okta/terraform-provider-okta [no test files]
=== RUN   TestAccAppSaml_crud
--- PASS: TestAccAppSaml_crud (51.24s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    51.502s
testing: warning: no tests to run
PASS
ok      github.com/okta/terraform-provider-okta/okta/internal/apimutex  (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/okta/terraform-provider-okta/okta/internal/transport (cached) [no tests to run]
?       github.com/okta/terraform-provider-okta/sdk     [no test files]

@ymylei ymylei changed the title SAML Cert Fix SAML SLO Cert Fix Jan 25, 2022
@monde
Copy link
Collaborator

monde commented Feb 2, 2022

@ymylei I'm going to cherry-pick d055788 into our v3.20.4 release as I don't want to bring in the go mod changes. Thanks for the fix.

@monde monde closed this Feb 2, 2022
@ymylei ymylei deleted the saml-fix branch February 3, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants