Add support for project user_on_demand_period attribute #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenelleman-okta
force-pushed
the
se/resource/project/add-on-demand-user-ttl
branch
from
bbcf39b
to
b7981af
Compare
| @@ -147,6 +152,7 @@ func resourceProjectCreate(ctx context.Context, d *schema.ResourceData, m interf | |||
| SSHSessionRecording: getBoolPtr(attributes.SSHSessionRecording, d, false), | |||
| GatewaySelector: getStringPtr(attributes.GatewaySelector, d, false), | |||
| SSHCertificateType: getStringPtr(attributes.SSHCertificateType, d, false), | |||
| UserOnDemandPeriod: getIntPtr(attributes.UserOnDemandPeriod, d, false), | |||
There was a problem hiding this comment.
Is UserOnDemandPeriod only need to be passed if create_server_users flag is set to true - slack link. I am not sure on this.
There was a problem hiding this comment.
I believe they're independent. Looking throughout the code UserOnDemandPeriod and CreateServerUser are applied separately.
sachinsaxena-okta
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.