Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Retry to Failed Acceptance Tests #88

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Add Retry to Failed Acceptance Tests #88

merged 1 commit into from
Nov 29, 2022

Conversation

stevenelleman-okta
Copy link
Contributor

There are at least two common classes of non-deterministic acceptance test failures: dependency download timeouts and failed locks (from tests being run in parallel).

The intention of a retry is to reduce false positives.

jamesatwill-okta
jamesatwill-okta approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@jamesatwill-okta jamesatwill-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gross, but until we get time to actually cache these somewhere reliable, hopefully it reduces the false negatives we've been getting.

@stevenelleman-okta stevenelleman-okta merged commit fd361c2 into master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesatwill-okta jamesatwill-okta jamesatwill-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenelleman-okta @jamesatwill-okta