-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve install script #264
Conversation
This is how
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these changes. There's one minor bug that needs to be fixed and I'll approve and merge this.
I'm about to commit a couple additional edits. I'll follow up. |
Usage examples: Invocation without arguments
Help
Installation into default location
Installation into custom location
|
I modified the installation script to require bash <(curl -fsSL https://raw.githubusercontent.com/oktadeveloper/okta-aws-cli-assume-role/master/bin/install.sh) -i It would be best to use a raw Github user content URL for the latest release. |
@aparkerlue thank you for your contribution. I have reviewed it and tested it. It is a big improvement in code and UX and it works. |
Problem Statement
Install script is (1) difficult to read, (2) does not print critical information about what it is doing, (3) silently modifies
~/.bash_profile
, and (4) writes files to multiple locations in the filesystem, a change that is difficult to revert unless there is a corresponding uninstallation mechanism.Solution
~/.bash_profile
and how to proceed post-installation~/.okta
so that uninstalling only involves removing that directory