Use port 8443 instead of 443 (#28)

* listen on port 8443 since that requires low-privilege * update to 0.5.1
okteto · Oct 14, 2023 · a7546a6 · a7546a6
1 parent 3cfea5d
commit a7546a6
Show file tree

Hide file tree

Showing 7 changed files with 32 additions and 13 deletions.
diff --git a/.stignore b/.stignore
@@ -28,4 +28,6 @@ webhook
 chart
 
 # build output
-output
+output
+
+cert-manager-webhook-civo-*.tgz
diff --git a/Dockerfile b/Dockerfile
@@ -26,5 +26,5 @@ COPY --from=builder /etc/group /etc/group
 COPY --from=builder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/
 COPY --chown=app:app --from=builder /usr/src/app/webhook /app/webhook
 USER app
-EXPOSE 443
+EXPOSE 8443
 ENTRYPOINT ["/app/webhook"]
diff --git a/README.md b/README.md
@@ -19,14 +19,16 @@ Follow the [instructions](https://cert-manager.io/docs/installation/) using the
 
 > Experimental, share your feedback!
 
+```bash
 helm install cert-manager-webhook-civo oci://ghcr.io/okteto/cert-manager-webhook-civo [--version 0.5.0]
+```
 
 #### Using public helm chart
 
 ```bash
 helm repo add okteto https://charts.okteto.com
 helm repo update
-helm install --namespace cert-manager cert-manager-webhook-civo okteto/cert-manager-webhook-civo
+helm install --namespace cert-manager cert-manager-webhook-civo okteto/cert-manager-webhook-civo [--version 0.5.0]
 ```
 
 #### From local checkout

diff --git a/chart/cert-manager-webhook-civo/Chart.yaml b/chart/cert-manager-webhook-civo/Chart.yaml
@@ -3,8 +3,8 @@ name: cert-manager-webhook-civo
 description: A webhook to use CIVO DNS as a DNS issuer for cert-manager
 home: https://github.com/okteto/cert-manager-webhook-civo
 type: application
-version: 0.5.0
-appVersion: 0.5.0
+version: "0.5.1"
+appVersion: "0.5.1"
 keywords:
 - cert-manager
 - letsencrypt

diff --git a/chart/cert-manager-webhook-civo/README.md b/chart/cert-manager-webhook-civo/README.md
@@ -1,6 +1,6 @@
 # cert-manager-webhook-civo
 
-![Version: 0.5.0](https://img.shields.io/badge/Version-0.5.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.5.0](https://img.shields.io/badge/AppVersion-0.5.0-informational?style=flat-square)
+![Version: 0.5.1](https://img.shields.io/badge/Version-0.5.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.5.1](https://img.shields.io/badge/AppVersion-0.5.1-informational?style=flat-square)
 
 A webhook to use CIVO DNS as a DNS issuer for cert-manager
 
@@ -10,14 +10,21 @@ A webhook to use CIVO DNS as a DNS issuer for cert-manager
 
 Follow the [instructions](https://cert-manager.io/docs/installation/) using the cert-manager documentation to install it within your cluster.
 
-### Webhook
+#### From the GitHub registry
+
+> Experimental, share your feedback!
+
+```bash
+helm install cert-manager-webhook-civo oci://ghcr.io/okteto/cert-manager-webhook-civo --version 0.5.1
+```
+
+#### From the public helm repository
 
 ```bash
 helm repo add okteto https://charts.okteto.com
 helm repo update
-helm install --namespace cert-manager cert-manager-webhook-civo okteto/cert-manager-webhook-civo
+helm install --namespace cert-manager cert-manager-webhook-civo okteto/cert-manager-webhook-civo --version 0.5.1
 ```
-
 ## Uninstalling
 
 To uninstall the webhook run

diff --git a/chart/cert-manager-webhook-civo/README.md.gotmpl b/chart/cert-manager-webhook-civo/README.md.gotmpl
@@ -11,14 +11,21 @@
 
 Follow the [instructions](https://cert-manager.io/docs/installation/) using the cert-manager documentation to install it within your cluster.
 
-### Webhook
+#### From the GitHub registry
+
+> Experimental, share your feedback!
+
+```bash
+helm install cert-manager-webhook-civo oci://ghcr.io/okteto/cert-manager-webhook-civo --version {{ .Version }}
+```
+
+#### From the public helm repository
 
 ```bash
 helm repo add okteto https://charts.okteto.com
 helm repo update
-helm install --namespace cert-manager cert-manager-webhook-civo okteto/cert-manager-webhook-civo
+helm install --namespace cert-manager cert-manager-webhook-civo okteto/cert-manager-webhook-civo --version {{ .Version }}
 ```
-
 ## Uninstalling
 
 To uninstall the webhook run

diff --git a/chart/cert-manager-webhook-civo/templates/deployment.yaml b/chart/cert-manager-webhook-civo/templates/deployment.yaml
@@ -26,6 +26,7 @@ spec:
           image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           args:
+            - --secure-port=8443
             - --tls-cert-file=/tls/tls.crt
             - --tls-private-key-file=/tls/tls.key
           env:
@@ -35,7 +36,7 @@ spec:
               value: {{ .Values.region | quote }}
           ports:
             - name: https
-              containerPort: 443
+              containerPort: 8443
               protocol: TCP
           livenessProbe:
             httpGet: