Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup configs and package.json files #100

Merged
merged 3 commits into from
May 9, 2023
Merged

refactor: cleanup configs and package.json files #100

merged 3 commits into from
May 9, 2023

Conversation

sadeghbarati
Copy link
Contributor

  • Use auto infer build configs for file entries, no need to use build.config file
  • Find a better pattern for mkdist
  • Update package.json

unbuild clean option is true by default no need to use additional script in package.json for removing dist content

For eslint, it should be handled in the root of project not in each package directory, which Idk how to config

@sadeghbarati
Copy link
Contributor Author

sadeghbarati commented May 9, 2023

  • use-callback-ref
  • use-controllable-ref
  • use-previous
  • use-size

I can't understand why these packages are separated and not in one package called @oku-ui/composables

@productdevbook
Copy link
Member

  • use-callback-ref
  • use-controllable-ref
  • use-previous
  • use-size

I can't understand why these packages are separated and not in one package called @oku-ui/composables

Great thought, I think you can combine this if you see fit? At the beginning, we continued without giving up the radix rule. To cut better ones on the way.

I think this is a nice cut.

You can do this in a different pr.

@productdevbook productdevbook merged commit 184665f into oku-ui:main May 9, 2023
@sadeghbarati
Copy link
Contributor Author

@productdevbook

If you decide to continue with .ts instead of .vue files, there is no need to use mkdist feature, mkdist feature was intended to copy .vue files in the destination without transferring SFC to JS
You can remove build.config files and bundle them with unbuild auto inferring option

@productdevbook
Copy link
Member

productdevbook commented May 9, 2023

I think the migration will be in .vue version 3.4. There are features that I expect to be supported. We can't switch to it right now. #101

sadeghbarati and others added 2 commits May 9, 2023 13:45
- use auto infer build configs for file entries
- find better pattern for mkdist
- update package.json
This was referenced May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants