chore(use-composable): add new useEscapeKeydown #248
Merged
+58
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 |
dammy001
suggested changes
Jul 27, 2023
|
@Cr0zy07 yeah, I think you should add test also. Thank you |
|
@dammy001, I have just added the test could you please check it 😅> |
dammy001
approved these changes
Jul 27, 2023
|
LGTM |
Merged
|
Hey @dammy001, I am sorry, I just removed a duplicated block of code form the test, but I think it merged before my last commit😶. Can we revert that or should I make another PR. Sorry again... |
|
Please create a new PR @Cr0zy07 |
Cr0zy07
added a commit
to Cr0zy07/primitives
that referenced
this pull request
Jul 27, 2023
This reverts commit b971406.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add useEscapeKeydown composable
Linked Issues
close #244
Additional context
Should I add a test for it because I only tried it on the Vue playground?