Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slot): new component #259

Merged
merged 8 commits into from
Aug 2, 2023
Merged

feat(slot): new component #259

merged 8 commits into from
Aug 2, 2023

Conversation

productdevbook
Copy link
Contributor

@productdevbook productdevbook commented Aug 1, 2023

close #232

Only store.ts should be set without changing any test settings in the file.

  • slot.ts needs further improvement according to tests.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 84.69% 1417 / 1673
🔵 Statements 84.69% 1417 / 1673
🔵 Functions 83.63% 46 / 55
🔵 Branches 78.87% 112 / 142
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/slot/src/slot.ts 94.54% 83.33% 100% 94.54% 40-42
packages/components/slot/src/utils.ts 100% 100% 100% 100%
Generated in workflow #495

@productdevbook productdevbook merged commit 247d535 into main Aug 2, 2023
@productdevbook productdevbook deleted the feat-slot branch August 2, 2023 10:15
@github-actions github-actions bot mentioned this pull request Aug 2, 2023
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@radix-ui/react-slot package needs to be written
1 participant