feat(core): package direction #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 |
productdevbook
changed the title
|
After checking this, let's ask to write a test if everything is correct @dammy001 |
dammy001
reviewed
Aug 3, 2023
| const DirectionProvider = defineComponent({ | ||
| name: 'DirectionProvider', | ||
| props: { | ||
| dir: { type: String as () => Direction, required: true }, |
There was a problem hiding this comment.
Suggested change
| dir: { type: String as () => Direction, required: true }, | |
| dir: { type: String as PropType<Direction>, required: true }, |
dammy001
reviewed
Aug 3, 2023
| @@ -0,0 +1,35 @@ | |||
| import { defineComponent, inject, provide } from 'vue' | |||
There was a problem hiding this comment.
Suggested change
| import { defineComponent, inject, provide } from 'vue' | |
| import { defineComponent, inject, provide, type PropType } from 'vue' |
|
@ramzzo can you add a few tests for this? |
productdevbook
changed the title
I have not written a test before, but I would like to try it. |
added 2 commits
August 3, 2023 10:54
productdevbook
approved these changes
Aug 3, 2023
|
❤️ |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #243