Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wasm simulate leak resource #3090

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

giskook
Copy link
Contributor

@giskook giskook commented Apr 10, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@giskook giskook marked this pull request as ready for review April 10, 2023 09:57
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023

Codecov Report

Merging #3090 (b76a5a4) into dev (a4c6b66) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head b76a5a4 differs from pull request most recent head 346fa60. Consider uploading reports for the commit 346fa60 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev    #3090      +/-   ##
==========================================
- Coverage   35.73%   35.73%   -0.01%     
==========================================
  Files         434      434              
  Lines       45731    45734       +3     
==========================================
  Hits        16342    16342              
- Misses      28202    28205       +3     
  Partials     1187     1187              
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 74.96% <0.00%> (-0.22%) ⬇️
x/wasm/simulate.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@giskook giskook force-pushed the zhangkai/wasm-sim-reuse-proxy-keeper branch from 0639c15 to 129e634 Compare April 10, 2023 12:18
@giskook giskook marked this pull request as draft April 10, 2023 13:26
@giskook giskook force-pushed the zhangkai/wasm-sim-reuse-proxy-keeper branch 3 times, most recently from 23f7148 to d0f1401 Compare April 11, 2023 07:40
@giskook giskook force-pushed the zhangkai/wasm-sim-reuse-proxy-keeper branch from 0b0dde9 to 346fa60 Compare April 11, 2023 07:42
@giskook giskook changed the title simulate reuse the proxy keeper Fix wasm simulate leak resource Apr 11, 2023
@giskook giskook marked this pull request as ready for review April 11, 2023 08:03
@KamiD KamiD merged commit 9fc23a8 into dev Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants