Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix iaviewer flags not valid #3123

Merged
merged 5 commits into from
Jun 19, 2023
Merged

fix iaviewer flags not valid #3123

merged 5 commits into from
Jun 19, 2023

Conversation

giskook
Copy link
Contributor

@giskook giskook commented May 2, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #3123 (42757e7) into dev (ec80d21) will not change coverage.
The diff coverage is n/a.

❗ Current head 42757e7 differs from pull request most recent head 7f4f05b. Consider uploading reports for the commit 7f4f05b to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev    #3123   +/-   ##
=======================================
  Coverage   36.07%   36.07%           
=======================================
  Files         441      441           
  Lines       46306    46306           
=======================================
  Hits        16707    16707           
  Misses      28362    28362           
  Partials     1237     1237           

@giskook giskook requested review from cwbhhjl and zjg555543 May 12, 2023 09:44
@KamiD KamiD merged commit 0046c91 into dev Jun 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants